feat(fcm): Support apns.live_activity_token field in FCM ApnsConfig
#2891
Conversation
| @@ -1725,6 +1725,21 @@ describe('Messaging', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| const invalidApnsLiveActivityTokens: any[] = [null, NaN, 0, 1, true, false] | |||
There was a problem hiding this comment.
perhaps we should add a test for valid payload?
There was a problem hiding this comment.
Sure thing. I added the tests with valid payloads for the live activity start | update | end events
| /** | ||
| * APN `live_activity_push_to_start_token` or `live_activity_push_token` to start or update live activities. | ||
| */ | ||
| live_activity_token?: string; |
There was a problem hiding this comment.
Exported names should be in lowerCamelCase formatting. Could you change this to liveActivityToken instead?
There was a problem hiding this comment.
Makes sense, thanks for your review!
I am not quite sure where to map the property liveActivityToken to live_activity_token as required for the HTTP API? https://firebase.google.com/docs/cloud-messaging/ios/live-activity
There was a problem hiding this comment.
also: Should the additional fields like dismissal-date content-state or attributes-type also get included and mapped? Those could also be [customData: string]: any typed
* feat(fcm): Support `live_activity_token` field on `ApnsConfig` * added validation * update documentation
live_activity_tokenfield onApnsConfigFixes #2875